[LLVMdev] R_ARM_ABS32 disassembly with integrated-as

[Greg Fitzgerald]

Thanks Renato.  I'm finishing up a patch for this and will post it to
llvm-commits.  But one concern, to create an ARMELFStreamer as you
recommend, I had to move MCELF.h to "include/llvm/MC" and added a
MCELFStreamer.h to the same directory.  That okay to do?

-Greg


On Wed, Oct 17, 2012 at 7:22 AM, Renato Golin <rengolin at systemcall.org>wrote:

> On 17 October 2012 15:05, Greg Fitzgerald <garious at gmail.com> wrote:
> > +  virtual void EmitMappingSymbol(bool IsData);
>
> I'd use an enum, or have multiple internal implementations...
>
> EmitDataMappingSymbol -> { nop on base class, on ARM, prints "$d" }
> EmitCodeMappingSymbol -> { nop on base class, calling either
> EmitThumbMappingSymbol or EmitARMMappingSymbol (private) on ARM }
>
>
> > +void MCELFStreamer::EmitMappingSymbol(bool IsData) {
> > +  // FIXME: The following is specific to the ARM.  This should be moved
> > +  //        to ARMAsmBackend.
>
> Maybe MCARMELFStreamer (or whatever sounds nicer than that). ARMAsm is
> a big bag of code and nowadays, most of it is format agnostic, I think
> (asm, elf).
>
>
> --
> cheers,
> --renato
>
> http://systemcall.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121017/06785194/attachment.html>