[LLVMdev] [polly] removing cloog dependence in the testsuite

Sebastian Pop spop at codeaurora.org
Mon Dec 3 10:42:59 PST 2012

Tobias Grosser wrote:
> On 12/03/2012 06:07 PM, Sebastian Pop wrote:
> >Tobias Grosser wrote:
> >>Regarding patch one and three: We already have the directory
> >>test/CodeGen and test/IslCodeGen. I propose to just leave the CLooG test
> >>cases in test/CodeGen, but to run them conditionally.
> >
> >I only know how to disable the test of a full directory, so if you want I can
> >disable all the CodeGen directory (and subdirectories) when Cloog is not
> >available.  Note that in my first patch I have moved only those tests not
> >working without cloog, and there are several testcases left in CodeGen that can
> >still be executed with ISL's codegen.
> I did not realize there are tests that work for both.
> What are those tests doing?

Here is what is left in my CodeGen dir:

polly/test/CodeGen$ find . -name '*.ll'

The OpenMP ones are already guarded with have_cloog, and the GPGPU ones are also

I could move all these except OpenMP/GPGPU to the Cloog/CodeGen dir.

> >>You can add the new isl test cases to  test/IslCodeGen.
> >>
> >
> >That's what patch 3 does, except for a minor rename to avoid a redundant CodeGen
> >in the dir names.
> I was basically aiming for having one test directory for one LLVM-IR
> pass. Instead of having shared test cases, I would rather copy those
> tests to the isl directory.

Then let's not use CodeGen for the Cloog code gen dir.  I have used
Cloog/CodeGen and Isl/CodeGen and I think this is consistent with what you want.

I can then move the remaining tests in Cloog/CodeGen and duplicate them in
Isl/CodeGen.  What do you think?

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

More information about the llvm-dev mailing list