[LLVMdev] Request for merge: GHC/ARM calling convention.

Duncan Sands baldrick at free.fr
Fri Oct 14 06:36:59 PDT 2011

Hi Karel,

> today is the last day[1] when someone might ask for feature merge into the LLVM
> 3.0 release. I'd like to ask you to merge attached patch. This is implementation
> of GHC calling convention on ARM platform which is made by Stephen Blackheath
> with few additions by me.

I don't know enough to comment on your patch technically, but it should at least
be perfectly safe to apply: I don't see how it can impact any code that doesn't
use the GHC calling convention.

>  const unsigned*
>  ARMBaseRegisterInfo::getCalleeSavedRegs(const MachineFunction *MF) const {
> +  bool ghcCall = false;
> +
> +  if (MF) {
> +    const Function *F = MF->getFunction();
> +    ghcCall = (F ? F->getCallingConv() == CallingConv::GHC : false);
> +  }

This bit looks dubious.  Why do you need to do it?

Ciao, Duncan.

More information about the llvm-dev mailing list