[LLVMdev] [PATCH][RFC] upgrade to googletest 1.6.0 (was Re: Build of latest llvm gives warning and error)
jay.foad at gmail.com
Tue Jul 26 03:16:36 PDT 2011
On 24 July 2011 10:59, Duncan Sands <baldrick at free.fr> wrote:
> Hi Edward,
>> Building of llvm with gcc-4.5.2-1 gives these warnings:
>> 1) Building FileManagerTest
>> "llvm: Compiling FileManagerTest.cpp for Debug+Asserts build
>> In member function 'virtual
>> warning: passing NULL to non-pointer argument 3 of 'static
>> testing::internal::EqHelper<true>::Compare(const char*, const char*,
>> const T1&, T2*) [with T1 = int, T2 = const clang::DirectoryEntry]'
> yes, they are annoying aren't they. They all come from google's unittest
> library. I think it is best to fix them upstream at google.
We're using googletest 1.5.0. These warnings seem to be fixed in
1.6.0, so here's a patch to upgrade us. Disclaimer: I've only tested
this by doing "make check-all" on Linux/x86_64.
Incidentally, the upgrade would have been much easier if we weren't
carrying local changes to support Haiku OS and Minix. Can these be
pushed upstream (or thrown away if no-one is using them)?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 76389 bytes
Desc: not available
More information about the llvm-dev