[LLVMdev] Subversion head: build problem on cygwin?
hs4233 at mail.mn-solutions.de
Thu Mar 13 00:34:53 PDT 2008
> Please attach patches as attachments (and name the file
> ".patch" just in case). Mail readers commonly munge them
> (e.g. by removing trailing whitespace) if not, which prevents
> the patch from applying.
I hope that this is not off-topic, but why is this?
I'm doing some amount of linux-driver kernel work, and there you
are urged to insert your patch directly into the body, not as an
attachment. What you have to do is to disable word-wrapping.
The various kernel subsystem maintainers then directly put the
patches from their mailclients into git, and trailing whitespace
doesn't seem to be a problem there.
The benefit is that various web-based mailing list archives have
the code snippets there directly, so they end up eventually in
google. You can also much better comment on those patches,
replying and writing your stuff in-between.
For reference, here's an excerpt from
7) No MIME, no links, no compression, no attachments. Just plain
Linus and other kernel developers need to be able to read and
comment on the changes you are submitting. It is important for
a kernel developer to be able to "quote" your changes, using
standard e-mail tools, so that they may comment on specific
portions of your code.
For this reason, all patches should be submitting
e-mail "inline". WARNING: Be wary of your editor's word-wrap
corrupting your patch, if you choose to cut-n-paste your patch.
Do not attach the patch as a MIME attachment, compressed or not.
Many popular e-mail applications will not always transmit a MIME
attachment as plain text, making it impossible to comment on your
code. A MIME attachment also takes Linus a bit more time to
process, decreasing the likelihood of your MIME-attached change
Exception: If your mailer is mangling patches then someone may
ask you to re-send them using MIME.
WARNING: Some mailers like Mozilla send your messages with
---- message header ----
Content-Type: text/plain; charset=us-ascii; format=flowed
---- message header ----
The problem is that "format=flowed" makes some of the mailers
on receiving side to replace TABs with spaces and do similar
changes. Thus the patches from you can look corrupted.
To fix this just make your mozilla defaults/pref/mailnews.js file
to look like:
pref("mailnews.send_plaintext_flowed", false); // RFC 2646=======
More information about the llvm-dev