[LLVMdev] LiveIntervals::handlePhysicalRegisterDef, unreachable MBBs

Chris Lattner sabre at nondot.org
Fri Jul 9 11:47:01 PDT 2004


On Fri, 9 Jul 2004, Vladimir Prus wrote:
> Finally, why I've started all this. I forgot to add machine CFG edge and got
> misterious crash. I've applied the attached patch, which checks that all
> basic blocks are reachable from function entry. Any comments on:
>
> - whether this check is reasonable?
> - what's the right place for the check? LiveVariables.cpp is the simplest I
> could find, but does not seem right.

Sure that makes sense, It's good to check invariants instead of crashing
mysteriously!  I've applied a modified version of your patch here:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20040705/015867.html

-Chris

-- 
http://llvm.cs.uiuc.edu/
http://www.nondot.org/~sabre/Projects/




More information about the llvm-dev mailing list