[LLVMdev] Headers & Libraries

Reid Spencer reid at x10sys.com
Fri Nov 14 14:03:01 PST 2003


On Fri, 2003-11-14 at 11:49, Alkis Evlogimenos wrote:
> On Friday 14 November 2003 01:22 pm, Reid Spencer wrote:
> > There is no separation of headers and cpp files. When I specify my
> > makefiles, I indicate which headers are public (installable) and which
> > are private (not installed).
> 
> IMO it is better to include with "" internal header files that are never 
> installed as is the case with all headers under lib. It makes file 
> self-documenting in terms of headers being public or private which in turn  
> helps when browsing the code as you know where to look for an included 
> header.

I agree whole heartedly. When I said "no separation of headers and cpp",
I meant that they XYZ.h and XYZ.cpp live in the same directory, the
XYZ.h isn't placed somewhere else in the directory structure.

> 
> > This arrangement has worked well and I'd advise LLVM to follow a similar
> > pattern to avoid end-user confusion (like mine) down the road.
> 
> As Chris said this is not of high priority right now. I think it would be nice 
> to have but I am not sure if everyone is convinced (or even anyone else in 
> the group). If/when we decide to go for it, it may be best if we open a bug 
> for it and let some contributor handle it, as there are much more important/
> interesting issues we need to address and the cost/benefit ratio of this 
> issue is very low.
> 
> In any case, we will get more discussion on this on Sunday, so let's hold our 
> breath until then...

Agreed. I'll volunteer to do the work but I won't bother if the result
is likely to be met with hostility :). I'd rather we all agree on a
plan, which might include doing nothing.  If the plan is acceptable then
I don't mind "making it so".

Reid
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20031114/9d8f35d2/attachment.sig>


More information about the llvm-dev mailing list