[llvm] [Intrinsics] Make `patchpoint.i64` generic on its return type (PR #85911)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 04:20:47 PDT 2024


================
@@ -5661,6 +5661,12 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) {
     }
     break;
   }
+  case Intrinsic::experimental_patchpoint: {
+    // Check that result type can fit in a single register.
+    Check(Call.getType()->isSingleValueType(),
----------------
arsenm wrote:

I think the comment (on isSingleValueType)  is misleading and not helpful, but in this case means "doesn't require decomposing into multiple EVTs to represent". I would just drop the comment

https://github.com/llvm/llvm-project/pull/85911


More information about the llvm-commits mailing list