[llvm] [GitHub][workflows] Use latest clang-format version 18.1.1 (PR #85502)

[Aiden Grossman via llvm-commits]

boomanaiden154 wrote:

> That RFC is about formatting entire codebases, and for me there is no consensus yet even though it seems more people favor at least the latest release of clang-format when formatting entire files.

Right. I'm aware of that. There was some discussion on holding back the version due to churn there, and there seemed to be a consensus on that point. Looking more closely at it, the point was made more in the context of after side-wide reformatting rather than the current state, like I originally though.

> The more relevant RFC is https://discourse.llvm.org/t/rfc-clang-format-github-action/73391. It seems the consensus is to use at least the latest release of clang-format for CI.

Yep. That does seem to be the current consensus and hasn't been adjusted at all like I originally though.

> There have been many bug fixes and a number of new options/features since clang-format 17.0.1. One of the new features is the support of .clang-format-ignore files, which can be used to ignore .td files mentioned in the RFC you linked above. There are bug fixes that fixed formatting errors in Polly. We also have a new clang-format style (from last November) that we can't really use unless the CI is bumped up to clang-format 18.1.1.

It sounds like it will be nice to take advantage of these features. Is it possible to include a short summary in the commit message next time?

The revert was a little bit overzealous on my part. Sorry about that. I still think we need to establish better policy on what exactly we want to do with tooling versioning, but that can be done elsewhere. I might try and see if I can start the process of codifying a policy somewhere this week.

https://github.com/llvm/llvm-project/pull/85502