[llvm] [AMDGPU] Improve detection of non-null addrspacecast operands (PR #82311)

via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 02:01:11 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 6c39fa9e9f198498ff7cf9646081437a0fc0882a 6ec7658d7f94eb4d2483da9f48bbc1eb27786048 -- llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp llvm/lib/Target/AMDGPU/SIISelLowering.cpp llvm/lib/Target/AMDGPU/SIISelLowering.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp b/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
index c11702b2c1..0edbbf7cb0 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
@@ -2048,7 +2048,9 @@ static bool isPtrKnownNeverNull(const Value *V, const DataLayout &DL,
 }
 
 bool AMDGPUCodeGenPrepareImpl::visitAddrSpaceCastInst(AddrSpaceCastInst &I) {
-  // Intrinsic doesn't support vectors, also it seems that it's often difficult to prove that a vector cannot have any nulls in it so it's unclear if it's worth supporting.
+  // Intrinsic doesn't support vectors, also it seems that it's often difficult
+  // to prove that a vector cannot have any nulls in it so it's unclear if it's
+  // worth supporting.
   if (I.getType()->isVectorTy())
     return false;
 
@@ -2069,7 +2071,9 @@ bool AMDGPUCodeGenPrepareImpl::visitAddrSpaceCastInst(AddrSpaceCastInst &I) {
 
   SmallVector<const Value *, 4> WorkList;
   getUnderlyingObjects(I.getOperand(0), WorkList);
-  if(!all_of(WorkList, [&](const Value* V) { return isPtrKnownNeverNull(V, *DL, *TM, SrcAS); }))
+  if (!all_of(WorkList, [&](const Value *V) {
+        return isPtrKnownNeverNull(V, *DL, *TM, SrcAS);
+      }))
     return false;
 
   IRBuilder<> B(&I);
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 67e10c53fe..1d90e003fe 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -1421,8 +1421,7 @@ void SITargetLowering::CollectTargetIntrinsicOperands(
   case Intrinsic::amdgcn_addrspacecast_nonnull: {
     // The DAG's ValueType loses the addrspaces.
     // Add them as 2 extra Constant operands "from" and "to".
-    unsigned SrcAS =
-        I.getOperand(0)->getType()->getPointerAddressSpace();
+    unsigned SrcAS = I.getOperand(0)->getType()->getPointerAddressSpace();
     unsigned DstAS = I.getType()->getPointerAddressSpace();
     Ops.push_back(DAG.getTargetConstant(SrcAS, SDLoc(), MVT::i32));
     Ops.push_back(DAG.getTargetConstant(DstAS, SDLoc(), MVT::i32));

``````````

</details>


https://github.com/llvm/llvm-project/pull/82311


More information about the llvm-commits mailing list