[PATCH] D158678: [NFC][AsmPrinter] Use std::visit in constructVariableDIEImpl

[Felipe de Azevedo Piovezan via Phabricator via llvm-commits]

fdeazeve accepted this revision.
fdeazeve added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:776
+      makeVisitor(
+          [=, &DV](const Loc::Single &Single) {
+            const DbgValueLoc *DVal = &Single.getValueLoc();
----------------
What do you think of implementing each of the visitors as a private member of `DwarfCompileUnit`?
I personally think this function could benefit from being split into different functions for readability, but this is a larger refactor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158678/new/

https://reviews.llvm.org/D158678