[PATCH] D158678: [NFC][AsmPrinter] Use std::visit in constructVariableDIEImpl

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 15:41:24 PDT 2023


scott.linder created this revision.
Herald added subscribers: hiraditya, dschuff.
Herald added a project: All.
scott.linder requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

This potentially has a slightly positive performance impact, as
std::visit can be implemented as a `switch`-like jump rather than
a series of `if`s.

More importantly, the reader can be confident is no overlap between the
cases.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158678

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158678.552909.patch
Type: text/x-patch
Size: 20737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230823/d7a619ff/attachment.bin>


More information about the llvm-commits mailing list