[PATCH] D155711: [SimplifyCFG] Hoist common instructions on Switch.

DianQK via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 30 07:27:35 PDT 2023


DianQK added a comment.

In D155711#4544449 <https://reviews.llvm.org/D155711#4544449>, @XChy wrote:

> Nice work to me! Just some nits here.
> Can you create two patches to better show the difference before/after transform? 
> The first patch includes your unoptimized testcases without the fold. (Your first commit)
> The second patch includes your optimized testcases and your code for the fold. (Your second commit, which is based on your first commit)
> And then let the first patch be the parent revision of the second patch through "Edit Related Revisions".

Thanks, I tried it out.
Too busy this weekend to update this patch. But I've split the patch into two. It should look better now.
I should think carefully about test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155711/new/

https://reviews.llvm.org/D155711



More information about the llvm-commits mailing list