[PATCH] D156520: [TII] NFCI: Simplify the interface for isTriviallyReMaterializable

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 07:26:57 PDT 2023


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:877
+        const MachineRegisterInfo &MRI = MF.getRegInfo();
+        return regIsPICBase(BaseReg, MRI);
+      }
----------------
piotr wrote:
> Doesn't it need the conditional change as in line 898 below?
Good spot, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156520/new/

https://reviews.llvm.org/D156520



More information about the llvm-commits mailing list