[PATCH] D156491: [RA] Split a virtual register in cold blocks if it is not assigned preferred physical register

Thu Jul 27 15:29:09 PDT 2023

Carrot added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/ran-out-of-sgprs-allocation-failure.mir:105
-  ; CHECK-NEXT:   renamable $sgpr60 = COPY killed renamable $sgpr76
-  ; CHECK-NEXT:   renamable $sgpr64_sgpr65_sgpr66_sgpr67_sgpr68_sgpr69_sgpr70_sgpr71_sgpr72_sgpr73_sgpr74_sgpr75_sgpr76_sgpr77_sgpr78_sgpr79_sgpr80_sgpr81_sgpr82_sgpr83_sgpr84_sgpr85_sgpr86_sgpr87_sgpr88_sgpr89_sgpr90_sgpr91_sgpr92_sgpr93_sgpr94_sgpr95 = SI_SPILL_S1024_RESTORE %stack.1, implicit $exec, implicit $sgpr32 :: (load (s1024) from %stack.1, align 4, addrspace 5)
-  ; CHECK-NEXT:   renamable $sgpr61 = COPY killed renamable $sgpr80
----------------
Carrot wrote:
> arsenm wrote:
> > This is a huge improvement (though this heuristic is probably not the reason it should have split)
> Thank you for the confirmation, I really don't what it is doing.
 I really don't know what it is doing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156491/new/

https://reviews.llvm.org/D156491