[PATCH] D156458: GVNSink: add test to show GVN-aware sinking

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 14:09:01 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Transforms/GVNSink/gvn-awareness.ll:50
+  %beam.addr = alloca i32, align 4
+  %i = alloca i32, align 4
+  store ptr %a, ptr %a.addr, align 8
----------------
Please at least run this through SROA. The test is a weird mix of completely unoptimized IR plus a GVN replacement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156458/new/

https://reviews.llvm.org/D156458



More information about the llvm-commits mailing list