[PATCH] D155459: [AArch64] Change the cost of vector insert/extract to 2

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 11:10:43 PDT 2023


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM.  I'll trust your benchmarking on this.



================
Comment at: llvm/test/Analysis/CostModel/AArch64/cttz.ll:108
 ; CHECK-LABEL: 'test_cttz_v8i16'
-; CHECK-NEXT:  Cost Model: Found an estimated cost of 50 for instruction: %cttz = call <8 x i16> @llvm.cttz.v8i16(<8 x i16> %a, i1 true)
+; CHECK-NEXT:  Cost Model: Found an estimated cost of 40 for instruction: %cttz = call <8 x i16> @llvm.cttz.v8i16(<8 x i16> %a, i1 true)
 ; CHECK-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: ret <8 x i16> %cttz
----------------
Worth noting the actual cost here is 4 instructions.  (We don't scalarize it; we lower using `cnt`.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155459/new/

https://reviews.llvm.org/D155459



More information about the llvm-commits mailing list