[PATCH] D155299: [AArch64][SVE2] Combine add+lsr to rshrnb for stores

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin accepted this revision.
kmclaughlin added a comment.
This revision is now accepted and ready to land.

Thanks @MattDevereau, there's one nit but otherwise LGTM!



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20178-20184
+    if (ResVT == MVT::nxv8i16) {
+      DoubleVT = MVT::nxv4i32;
+    } else if (ResVT == MVT::nxv16i8) {
+      DoubleVT = MVT::nxv8i16;
+    } else {
+      return SDValue();
+    }
----------------
nit: The braces here aren't necessary


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20191-20197
+    if (ResVT == MVT::nxv8i16) {
+      DoubleVT = MVT::nxv4i32;
+    } else if (ResVT == MVT::nxv16i8) {
+      DoubleVT = MVT::nxv8i16;
+    } else {
+      return SDValue();
+    }
----------------
As above :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155299/new/

https://reviews.llvm.org/D155299