[PATCH] D156422: AMDGPU: Always custom lower extract_subvector

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 05:24:10 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, foad, Joe_Nash, Pierre-vh.
Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

The patterns were ripped out in
a4a3ac10cb1a40ccebed4e81cd7e94f1eb71602d <https://reviews.llvm.org/rGa4a3ac10cb1a40ccebed4e81cd7e94f1eb71602d> so this always needs to be
custom lowered. I absolutely hate how difficult it is to write tests
for these, I have no doubt there are more of these hidden.

      

Fixes #64142


https://reviews.llvm.org/D156422

Files:
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/extract-subvector-16bit.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156422.544723.patch
Type: text/x-patch
Size: 28229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/3b8c38e1/attachment.bin>


More information about the llvm-commits mailing list