[PATCH] D156235: [MachineBlockPlacement] Remove the pad limit for no-fallthrough loops

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 12:01:31 PDT 2023


dmgreen added a comment.

I think if someone specifies -max-bytes-for-alignment, the command line argument should not be ignored for non-fallthrough loop headers. It should ideally take precedence over this heuristic.

I would also make this AArch64 specific, as it has not been verified on any other architectures. That is debatable though, it just might be using more space than is desirable. If that can't be done via a basic block arg, maybe getMaxPermittedBytesForAlignment could take a bool indicating whether it is non-fallthrough loop header.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156235/new/

https://reviews.llvm.org/D156235



More information about the llvm-commits mailing list