[PATCH] D154987: [lit] Implement PYTHON directive and config.prologue

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

In D154987#4529228 <https://reviews.llvm.org/D154987#4529228>, @sammccall wrote:

> I have to offer a dissenting voice here...

I am also unsure whether this patch is the right direction for LIT. One major advantage of LIT is that it is "constrained" and hence:

- the number of "idioms" is rather limited, so it's relatively easy to switch between sub-projects and still be able to parse/contribute new tests,
- while "creativity" is limited (it's not Python), it allows us to keep the tests relatively coherent.

While new LIT features make it resemble Python more and more, it is still quite far from Python itself. Also, there's a difference between "adding _a_ new feature" vs "allowing arbitrary Python code". But I appreciate that LIT has it's limitations and we need to evolve it.

> That is, a lit with PYTHON should make tests easier to read and should make lit easier to maintain than a lit with its own evolving scripting language.

I am not sure. It will give developers more power, but with extra power comes extra responsibility :) Also, this "power" will require people to understand LIT internals better, right? That wouldn't be a bad thing, but I just want to highlight that there are some advantages of having a dedicated scripting language (which doesn't require one to understand how LIT is implemented).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154987/new/

https://reviews.llvm.org/D154987