[PATCH] D155943: [NFC] Update formatting of some symbolizer tests

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:19:55 PDT 2023


jhenderson added a comment.

In D155943#4529586 <https://reviews.llvm.org/D155943#4529586>, @dblaikie wrote:

> (personally, I'd probably standardize on not prefixing everything with `#` since it just means /everything/ in the file is prefixed, so it maybe doesn't add value?)

I'm happy to do it this way (I personally have no preference, as long as comments are clearly distinguished from real lit/FileCheck stuff). You can reduce the diff size whilst still maintaining this clear distinction by following @dblaikie's approach, at least with some of the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155943/new/

https://reviews.llvm.org/D155943



More information about the llvm-commits mailing list