[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

Mon Jul 24 09:26:44 PDT 2023

b-sumner added a comment.

In D156040#4528606 <https://reviews.llvm.org/D156040#4528606>, @arsenm wrote:

> In D156040#4526036 <https://reviews.llvm.org/D156040#4526036>, @JonChesterfield wrote:
>
>> I don't see how this conveys any information. The compiler writes the stack size to be allocated. If it doesn't know what is sufficient, it's going to request some maximum and hope for the best.
>
> That was the old broken workaround for the old bit that was never actually implemented in the runtime. The runtime now does properly respect some field to switch to interpreting the reported size as a minimum and then allocates the max of that minimum and some API provided size value

"runtime" == "hip/opencl runtime".  The openmp runtime needs to do the same if not being done already.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156040/new/

https://reviews.llvm.org/D156040