[PATCH] D153499: [RISCV] Add support for custom CSRs for Sifive S76.

garvit gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 10:35:08 PDT 2023


garvitgupta08 marked 3 inline comments as done.
garvitgupta08 added inline comments.


================
Comment at: llvm/test/MC/RISCV/xsfcie-invalid.s:5
+
+csrr t1, mbpm # CHECK: :[[@LINE]]:10: error: system register use requires an option to be enabled
+
----------------
craig.topper wrote:
> Are we able to tell the user which option?
The existing implementation will need change to tell precisely which options need to be enabled. For now, this patch is using the same implementation of erroring out as earlier if subtarget does not have required features.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153499/new/

https://reviews.llvm.org/D153499



More information about the llvm-commits mailing list