[PATCH] D143018: [DAGCombiner][NFC] Factor out ByteProvider

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 04:08:18 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8401
 /// *ExtractVectorElement
-static const std::optional<ByteProvider>
+static const std::optional<ByteProvider<SDNode *>>
 calculateByteProvider(SDValue Op, unsigned Index, unsigned Depth,
----------------
Is there anywhere we can safely put a typedef to avoid carrying around the same template argument?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143018/new/

https://reviews.llvm.org/D143018



More information about the llvm-commits mailing list