[PATCH] D143018: [DAGCombiner][NFC] Factor out ByteProvider

[Jeffrey Byrnes via Phabricator via llvm-commits]

jrbyrnes updated this revision to Diff 520858.
jrbyrnes added a comment.

Hi @barannikov88 -- thanks for your comments. I tend to agree that it is not "abstract enough" for ADT as it is basically an ISel util -- I have moved it into include/llvm/CodeGen

That said, I think it should be generic in that it should be agnostic between SDNode and SDValu -- DAGCombiner currently uses SDNode but I am working on a patch which calculates ByteProviders in terms of SDValues https://reviews.llvm.org/D142782 . Eventually we will want to extend this work to GlobalISel as well, so it seems we may also want MachineInstrs as the Src.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143018/new/

https://reviews.llvm.org/D143018

Files:
  llvm/include/llvm/CodeGen/ByteProvider.h
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143018.520858.patch
Type: text/x-patch
Size: 10219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230509/5c19328e/attachment.bin>