[PATCH] D149448: [Pipelines] Move LTO SCCP and BDCE out of addVectorPasses()

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

> Even without a full reproducer, would it be possible to share the IR diff for the BDCE pass for that particular test? Just to get an idea for what makes it beneficial to run it after runtime unrolling. (Note that I've currently scheduled it before full unrolling as well, but based on your description it sounds like moving it after full unrolling wouldn't help either.)

Yeah, it appears to need to run after the unrolling in vectorPasses (or after vectorPasses). After full unrolling didn't seem to help.

I wouldn't want to block things just for this case. There is chance it is just a bad benchmark that doesn't store any useful results. It looks like it removed interconnected phi nodes that have no other uses. I will try to send you what I can get, but like I said I only saw it come up in this one case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149448/new/

https://reviews.llvm.org/D149448