[PATCH] D149448: [Pipelines] Move LTO SCCP and BDCE out of addVectorPasses()

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 03:57:04 PDT 2023


nikic added a comment.

In D149448#4309461 <https://reviews.llvm.org/D149448#4309461>, @dmgreen wrote:

> Hello. This sounds OK, but apparently it can be pretty beneficial to run BDCE after the second round of unrolling. Unfortunately this may be wrapped up with some downstream compiler changes with a downstream test, it would make it hard to produce a reproducer. It is apparently after the second round of unrolling in this particular test. Otherwise I don't see any issues past that one case.

Even without a full reproducer, would it be possible to share the IR diff for the BDCE pass for that particular test? Just to get an idea for what makes it beneficial to run it after runtime unrolling. (Note that I've currently scheduled it before full unrolling as well, but based on your description it sounds like moving it after full unrolling wouldn't help either.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149448/new/

https://reviews.llvm.org/D149448



More information about the llvm-commits mailing list