[PATCH] D149021: [TTI][ASAN] Introduce TTI::getInterestingMemoryOperand.

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 08:45:59 PDT 2023


kparzysz added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:889
+  // Return InterestingMemoryOperand of Intrinsic \p II.
+  InterestingMemoryOperand getInterestingMemoryOperand(IntrinsicInst *II) const;
+
----------------
The term "interesting" is meaningless in this context.  We should use more descriptive names in files that are shared among multiple users.


================
Comment at: llvm/include/llvm/Support/InterestingMemoryOperand.h:1
 //===--------- Definition of the AddressSanitizer class ---------*- C++ -*-===//
 //
----------------
The comment is out of date.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149021/new/

https://reviews.llvm.org/D149021



More information about the llvm-commits mailing list