[PATCH] D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 22:21:21 PDT 2020


cishida created this revision.
cishida added reviewers: plotfi, haowei, amontanez.
Herald added subscribers: ributzka, hiraditya.
Herald added a project: LLVM.
cishida requested review of this revision.

It appears for Swift there was confusing errors when trying to parse APINotes, when libAPINotes and libInterfaceStub are linked, they both export symbol
`__ZN4llvm4yaml7yamlizeINS_12VersionTupleEEENSt3__19enable_ifIXsr16has_ScalarTraitsIT_EE5valueEvE4typeERNS0_2IOERS5_bRNS0_12EmptyContextE`, and discovered
same symbol defined within llvm-ifs. This adds a wrapper over both usages of `VersionTuple` to account for the specific validiation that done in YAMLTraits.

fixes: rdar://problem/70450563


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89764

Files:
  llvm/include/llvm/InterfaceStub/ELFStub.h
  llvm/include/llvm/InterfaceStub/TBEHandler.h
  llvm/lib/InterfaceStub/TBEHandler.cpp
  llvm/tools/llvm-ifs/llvm-ifs.cpp
  llvm/unittests/InterfaceStub/ELFYAMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89764.299261.patch
Type: text/x-patch
Size: 4985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201020/34e6bb95/attachment-0001.bin>


More information about the llvm-commits mailing list