[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""

[Dan Weber via Phabricator via llvm-commits]

dweber added a comment.

In D88773#2326620 <https://reviews.llvm.org/D88773#2326620>, @tlively wrote:

> - Add masking of lane value and new tests
>
> @dweber, you were totally right that this needed to be masked. In particular, when the lane contains a negative number, getZExtValue returns a very large 64-bit constant that needs to be truncated. Thanks for pressing me on that!

Yeah... I had an eerie feeling something like that could happen -- I just couldn't put my finger on it.  Really.  Thanks go to you for taking care of this.

Do you know if it would still be the case if you were using getLimitedValue instead of getZExtValue? I want to say yes, but I'm not entirely sure how these two work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88773/new/

https://reviews.llvm.org/D88773