[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 20:49:25 PDT 2020


tlively updated this revision to Diff 297752.
tlively added a comment.

- Add masking of lane value and new tests

@dweber, you were totally right that this needed to be masked. In particular, when the lane contains a negative number, getZExtValue returns a very large 64-bit constant that needs to be truncated. Thanks for pressing me on that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88773/new/

https://reviews.llvm.org/D88773

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/test/CodeGen/WebAssembly/simd-build-vector.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88773.297752.patch
Type: text/x-patch
Size: 9791 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201013/0e33def9/attachment.bin>


More information about the llvm-commits mailing list