[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 10:54:21 PDT 2020


jrtc27 added inline comments.


================
Comment at: llvm/docs/TableGen/BackGuide.rst:565
 
-* ``getDef(``\ *name*\ ``)`` return a ``Record`` reference for the named
   concrete record.
----------------
Paul-C-Anagnostopoulos wrote:
> jrtc27 wrote:
> > Not relevant to this diff, please just commit this separately as a trivial grammar fix.
> I'm correcting errors in this new document as I find them. Is it really necessary to patch each one separately?
No, but I think "correcting a bunch of errors" should be a separate commit (it can be a single commit though) from "adding this new function and documenting it".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88832/new/

https://reviews.llvm.org/D88832



More information about the llvm-commits mailing list