[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/docs/TableGen/BackGuide.rst:55-62
-all the information about that class or record. The ``RecordKeeper`` class
-defines a type that must be used to declare these maps if they are requested
-directly.
-
-.. code-block:: text
-
-  using RecordMap = std::map<std::string, std::unique_ptr<Record>,
----------------
jrtc27 wrote:
> What happened here? Why has this gone?
The RecordMap and GlobalMap types are not public. I was mistaken when I first wrote the document.


================
Comment at: llvm/docs/TableGen/BackGuide.rst:565
 
-* ``getDef(``\ *name*\ ``)`` return a ``Record`` reference for the named
   concrete record.
----------------
jrtc27 wrote:
> Not relevant to this diff, please just commit this separately as a trivial grammar fix.
I'm correcting errors in this new document as I find them. Is it really necessary to patch each one separately?


================
Comment at: llvm/docs/TableGen/BackGuide.rst:704
 file locations.  To make error reporting easier, five error reporting
-functions are provided, each with four overloads. [all combinations to come]
 
----------------
jrtc27 wrote:
> What's this doing here? You're not touching error reporting.
I removed this because all 20 combinations will probably never be added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88832/new/

https://reviews.llvm.org/D88832