[PATCH] D88995: Support vectors in CastInst::isBitOrNoopPointerCastable

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri resigned from this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

In D88995#2323636 <https://reviews.llvm.org/D88995#2323636>, @reames wrote:

> In D88995#2323615 <https://reviews.llvm.org/D88995#2323615>, @lebedev.ri wrote:
>
>> In D88995#2323613 <https://reviews.llvm.org/D88995#2323613>, @reames wrote:
>>
>>> To your actual question - which again, I believe is off topic for this review - we could consider extending the load transform to select the "better" of the two types, and potentially insert a cast for the former set of uses instead of the later.
>>
>> No, that was not my question.
>> My question was:
>>
>> In D88995#2318600 <https://reviews.llvm.org/D88995#2318600>, @lebedev.ri wrote:
>>
>>> In the most original unoptimized IR, were there actually two different loads, one of a pointer and one of an integer?
>
> Ah, we're talking past each other.  There is no "unoptimized IR" that I'm working from.  I found this while doing an audit of code for consistent handling of non-integral pointers, nothing more.  Given that, I can not answer the question you asked.

How is it "again" if this is the first time you're stating this?
Apologies if i'm being blind and it was said before.

So IOW this isn't actually *known* to happen in reality,
it's a missed opportunity in the existing fold that was found
solely by looking at the folds, not IR.

Please do actually state that in the patches description,
and please do consider saying things like that beforehand
in next patches..

With that in light i guess this should be fine.

> Again, I believe this entire topic of irrelevant for this particular review.  If you want to discuss further, I'm happy to jump on a call next week and brainstorm, but continuing the conversation on the broader direction you want to move in here is not helpful.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88995/new/

https://reviews.llvm.org/D88995