[PATCH] D88995: Support vectors in CastInst::isBitOrNoopPointerCastable

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 10 14:53:25 PDT 2020


reames added a comment.

In D88995#2323615 <https://reviews.llvm.org/D88995#2323615>, @lebedev.ri wrote:

> In D88995#2323613 <https://reviews.llvm.org/D88995#2323613>, @reames wrote:
>
>> To your actual question - which again, I believe is off topic for this review - we could consider extending the load transform to select the "better" of the two types, and potentially insert a cast for the former set of uses instead of the later.
>
> No, that was not my question.
> My question was:
>
> In D88995#2318600 <https://reviews.llvm.org/D88995#2318600>, @lebedev.ri wrote:
>
>> In the most original unoptimized IR, were there actually two different loads, one of a pointer and one of an integer?

Ah, we're talking past each other.  There is no "unoptimized IR" that I'm working from.  I found this while doing an audit of code for consistent handling of non-integral pointers, nothing more.  Given that, I can not answer the question you asked.

Again, I believe this entire topic of irrelevant for this particular review.  If you want to discuss further, I'm happy to jump on a call next week and brainstorm, but continuing the conversation on the broader direction you want to move in here is not helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88995/new/

https://reviews.llvm.org/D88995



More information about the llvm-commits mailing list