[PATCH] D82588: [DSE] Look through memory PHI arguments when removing noop stores in MSSA.

[Zoe Carver via Phabricator via llvm-commits]

zoecarver added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/noop-stores.ll:124
+
+; Don't remove "redundant" store if %p is possibly stored to.
+define i32 @test46(i1 %c, i32* %p, i32* %p2, i32 %i) {
----------------
xbolva00 wrote:
> use update_test_checks.py script to regenerate test checks?
I think the below checks are sufficient. Is the norm to use `update_test_checks.py`? If you'd like, I can submit another patch after updating the tests. 


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/noop-stores.ll:237
+
+; TODO: Remove both redundant stores if loaded value is in another block inside a loop.
+define i32 @test47(i1 %c, i32* %p, i32 %i) {
----------------
xbolva00 wrote:
> No longer todo?
This is still a TODO. See the `X-CHECK`s below. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82588/new/

https://reviews.llvm.org/D82588