[PATCH] D82588: [DSE] Look through memory PHI arguments when removing noop stores in MSSA.

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 01:37:51 PDT 2020


xbolva00 added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/noop-stores.ll:124
+
+; Don't remove "redundant" store if %p is possibly stored to.
+define i32 @test46(i1 %c, i32* %p, i32* %p2, i32 %i) {
----------------
use update_test_checks.py script to regenerate test checks?


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/noop-stores.ll:237
+
+; TODO: Remove both redundant stores if loaded value is in another block inside a loop.
+define i32 @test47(i1 %c, i32* %p, i32 %i) {
----------------
No longer todo?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82588/new/

https://reviews.llvm.org/D82588



More information about the llvm-commits mailing list