[PATCH] D87697: Do not construct std::string from nullptr

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 14:09:20 PDT 2020


nikic added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1277
     llvm_unreachable("unexpected type");
     break;
   case Type::IntegerTyID: {
----------------
@mclow.lists There already is a call to llvm_unreachable here ^ so the second call to unreachable seems redundant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87697/new/

https://reviews.llvm.org/D87697



More information about the llvm-commits mailing list