[PATCH] D87697: Do not construct std::string from nullptr

Marshall Clow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 13:32:29 PDT 2020


mclow.lists added a comment.

I would rather see:

  llvm_unreachable("unexpected type");
  return ""; // or string()

i.e, keep the call to unreachable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87697/new/

https://reviews.llvm.org/D87697



More information about the llvm-commits mailing list