[PATCH] D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 12:53:38 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/dse-libcalls.ll:19
+; NEWPM-NEXT:    call void @llvm.lifetime.start.p0i8(i64 256, i8* nonnull [[BUF]])
+; NEWPM-NEXT:    [[TMP1:%.*]] = call i8* @strcpy(i8* nonnull [[BUF]], i8* nonnull dereferenceable(1) [[SRC:%.*]])
+; NEWPM-NEXT:    call void @llvm.lifetime.end.p0i8(i64 256, i8* nonnull [[BUF]])
----------------
I think the NPM would require `-aa-pipeline=basic-aa`. But given that the interaction between -infer-attrs/-dse is very small, I think it would be best to move the checks to the existing `lib calls.ll`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88328/new/

https://reviews.llvm.org/D88328



More information about the llvm-commits mailing list