[PATCH] D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 12:43:22 PDT 2020


fhahn added reviewers: jdoerfert, lebedev.ri.
fhahn added a comment.

I think it would be good to update the commit message to just state that this adds `no capture` and `write only` to the first arg of `strcpy` & co. It also unifies `strcpy` & `stpcpy` handling. might be good to do separately first.



================
Comment at: llvm/test/Transforms/PhaseOrdering/dse-libcalls.ll:11
+
+define void @dse_strcpy(i8* nocapture readonly %src) {
+; OLDPM-LABEL: @dse_strcpy(
----------------
Can we just add those tests to `llvm/test/Transforms/DeadStoreElimination/MSSA/libcalls.ll`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88328/new/

https://reviews.llvm.org/D88328



More information about the llvm-commits mailing list