[PATCH] D88033: [SVE][CodeGen] Legalisation of integer -> floating point conversions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 11:28:57 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:987
       if (isTypeLegal(VT)) {
+        setOperationAction(ISD::CONCAT_VECTORS, VT, Custom);
         setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom);
----------------
Thinking about it a little more, we probably only want to mark CONCAT_VECTORS "Custom" for vectors with four or more elements.  It's never legal if the result is a two-element vector.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88033/new/

https://reviews.llvm.org/D88033



More information about the llvm-commits mailing list