[PATCH] D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 16:52:49 PDT 2020


rnk added a comment.

In D88127#2291342 <https://reviews.llvm.org/D88127#2291342>, @zequanwu wrote:

> That's reverted. (https://reviews.llvm.org/rG91aed9bf975f1e4346cc8f4bdefc98436386ced2). I don't know if I should put two patches together.

Well, normally code that has been reverted cannot be relanded without changes, so it's common to revert the revert locally, edit it, and reupload it for code review. I believe you can even "reopen" the closed code review issue that you used for the first review, and it will show the changes you made clearly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88127/new/

https://reviews.llvm.org/D88127



More information about the llvm-commits mailing list