[PATCH] D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 16:20:26 PDT 2020


zequanwu added a comment.

In D88127#2291320 <https://reviews.llvm.org/D88127#2291320>, @rnk wrote:

> I'm saying the fix belongs in TargetObjectFileLoweringImpl.cpp, which is the point where we translate from IR to assembly. We can't fix this after producing assembly, because we don't know what symbols are marked dllimport at that point.

That's reverted. (https://reviews.llvm.org/rG91aed9bf975f1e4346cc8f4bdefc98436386ced2). I don't know if I should put two patches together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88127/new/

https://reviews.llvm.org/D88127



More information about the llvm-commits mailing list