[PATCH] D87286: AArch64: make sure jump table entries can reach entire image

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 15:52:35 PDT 2020


efriedma accepted this revision.
efriedma added a comment.

In D87286#2280553 <https://reviews.llvm.org/D87286#2280553>, @efriedma wrote:

>> Further, because of MachO limitations on relocation addends (have I said how much I hate that format in the last week? Time to do it again), it can't be anything inside the function, leaving only the function symbol itself.
>
> LLVM seems to accept "adrp x8, (f+1)@PAGE"; does that not do the right thing?

Oh, that has limited range; I guess it doesn't help.

In that case, LGTM the way it is, I guess.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87286/new/

https://reviews.llvm.org/D87286



More information about the llvm-commits mailing list