[PATCH] D87286: AArch64: make sure jump table entries can reach entire image

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 15:46:20 PDT 2020


efriedma added a comment.

> Further, because of MachO limitations on relocation addends (have I said how much I hate that format in the last week? Time to do it again), it can't be anything inside the function, leaving only the function symbol itself.

LLVM seems to accept "adrp x8, (f+1)@PAGE"; does that not do the right thing?

I'm a little concerned about the potential performance impact of the isNotDuplicable marking (that's the one change that impacts compressed jump tables), but your results seem to indicate it isn't significant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87286/new/

https://reviews.llvm.org/D87286



More information about the llvm-commits mailing list