[PATCH] D86928: [SVE][CodeGen] Fix TypeSize/ElementCount related warnings in sve-split-store.ll

Wed Sep 16 19:33:58 PDT 2020

efriedma added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2235
+  if (V.getValueType().isScalableVector())
+    return SDValue();
+
----------------
david-arm wrote:
> efriedma wrote:
> > efriedma wrote:
> > > I don't think we should ever get here with a scalable vector?  We should guard the creation of DemandedElts.
> > Is `if (!DemandedElts)` related to this patch somehow?
> Hi @efriedma, your first comment here said "We should guard the creation of DemandedElts" so I thought this is what you meant. Are you saying that I shouldn't have to change anything at all in this function and that all callers of this function should create an empty DemandedElts for scalable vectors?
You shouldn't have to change anything at all; the callers should deal with it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86928/new/

https://reviews.llvm.org/D86928