[PATCH] D86928: [SVE][CodeGen] Fix TypeSize/ElementCount related warnings in sve-split-store.ll

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2235
+  if (V.getValueType().isScalableVector())
+    return SDValue();
+
----------------
efriedma wrote:
> efriedma wrote:
> > I don't think we should ever get here with a scalable vector?  We should guard the creation of DemandedElts.
> Is `if (!DemandedElts)` related to this patch somehow?
Hi @efriedma, your first comment here said "We should guard the creation of DemandedElts" so I thought this is what you meant. Are you saying that I shouldn't have to change anything at all in this function and that all callers of this function should create an empty DemandedElts for scalable vectors?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86928/new/

https://reviews.llvm.org/D86928