[PATCH] D87744: [RegisterCoalescer] passs Undefs to extendToIndices()

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 07:07:56 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/coalescer-removepartial-extend-undef-subrange.mir:20
+# chain and assert:
+# "Use of $noreg does not have a corresponding definition on every path
+#  LLVM ERROR: Use not jointly dominated by defs"
----------------
$noreg doesn't have liveness?


================
Comment at: llvm/test/CodeGen/AMDGPU/coalescer-removepartial-extend-undef-subrange.mir:29
+  bb.0:
+    successors: %bb.1, %bb.2
+    liveins: $sgpr2, $sgpr3, $vgpr3
----------------
Can you reduce this any further? -run-pass=none will also compact the register numbers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87744/new/

https://reviews.llvm.org/D87744



More information about the llvm-commits mailing list